fix(pillars): ensure `addusers` & `delusers` are lists

[myii]

PR progress checklist (to be filled in by reviewers)

• [ ] Changes to documentation are appropriate (or tick if not required)
• [x] Changes to tests are appropriate (or tick if not required)
• [x] Reviews completed

---

What type of PR is this?

Primary type

• [ ] [build] Changes related to the build system
• [ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ ] [ci] Changes to the continuous integration configuration
• [ ] [feat] A new feature
• [x] [fix] A bug fix
• [ ] [perf] A code change that improves performance
• [ ] [refactor] A code change that neither fixes a bug nor adds a feature
• [ ] [revert] A change used to revert a previous commit
• [ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [ ] [docs] Documentation changes
• [ ] [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Found this problem some time back while testing saltcheck tests with this formula.

https://github.com/saltstack-formulas/users-formula/blob/5e6846b1735406395bec572f0b58c1ed39189f11/users/init.sls#L14-L21

• https://docs.saltstack.com/en/latest/ref/states/all/salt.states.group.html#salt.states.group.present
  • Docs show that both have to be lists.

Pillar / config required to test the proposed changes

Found with the following saltcheck tests:

{%-     for section in ['members'] %}
{%-       for member in (setting.get('addusers', []) + setting.get('members', [])) %}
validate_users_group_present_{{ group }}_{{ section }}_{{ member }}_present:
  module_and_function: group.info
  args:
    - '{{ group }}'
  assertion: assertIn
  assertion_section: '{{ section }}'
  expected-return: '{{ member }}'
{%-       endfor %}
{%-       for member in setting.get('delusers', []) %}
validate_users_group_present_{{ group }}_{{ section }}_{{ member }}_absent:
  module_and_function: group.info
  args:
    - '{{ group }}'
  assertion: assertNotIn
  assertion_section: '{{ section }}'
  expected-return: '{{ member }}'
{%-       endfor %}
{%-     endfor %}

Debug log showing how the proposed changes work

Documentation checklist

• [ ] Updated the README (e.g. Available states).
• [x] Updated pillar.example.

Testing checklist

• [ ] Included in Kitchen (i.e. under state_top).
• [ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• [x] Updated the relevant test pillar.

Additional context

[saltstack-formulas-travis]

:tada: This PR is included in version 0.48.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: