Closed jasonious closed 3 years ago
@jasonious Thanks for this PR. Technically, there isn't a problem here. The full discussion is captured here:
After the improvements made to salt-lint
after that report, we've set this across a large number of formulas in this org:
And we have salt-lint
running in Travis for each of these formulas.
None of this prevents this PR being merged, or the one in the postfix-formula
. However, there's not much benefit to doing this in other formulas, so hopefully this can save you some time and effort!
Merged, thanks @jasonious!
:tada: This PR is included in version 0.48.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Thanks for the discussion links. I am running just the generic linter and went from there without too much investigation. I'll leave the rest be, but nice to know I can pull in the latest for these two and they'll "just work" in our states now. cheers.
salt linters complain about these.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Changed raw file modes to the more preferred style of quoted with a leading zero
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context