saltstack-formulas / users-formula

Configure users via pillar
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
99 stars 362 forks source link

style: quote numbers and file modes #222

Closed jasonious closed 3 years ago

jasonious commented 3 years ago

salt linters complain about these.

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Changed raw file modes to the more preferred style of quoted with a leading zero

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

myii commented 3 years ago

@jasonious Thanks for this PR. Technically, there isn't a problem here. The full discussion is captured here:

After the improvements made to salt-lint after that report, we've set this across a large number of formulas in this org:

https://github.com/saltstack-formulas/users-formula/blob/b5aac7797cf8df7a086d001d271e07179c40a9ff/.salt-lint#L9-L12

And we have salt-lint running in Travis for each of these formulas.


None of this prevents this PR being merged, or the one in the postfix-formula. However, there's not much benefit to doing this in other formulas, so hopefully this can save you some time and effort!

myii commented 3 years ago

Merged, thanks @jasonious!

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 0.48.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

jasonious commented 3 years ago

Thanks for the discussion links. I am running just the generic linter and went from there without too much investigation. I'll leave the rest be, but nice to know I can pull in the latest for these two and they'll "just work" in our states now. cheers.