saltstack-formulas / users-formula

Configure users via pillar
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
99 stars 362 forks source link

googleauth: newline was being eaten #228

Closed unilogicbv closed 2 years ago

unilogicbv commented 2 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

myii commented 2 years ago

@unilogicbv Thanks for the fix, that's been merged.

Note, we're using semantic-release across our formulas, so the commit message format is important, hence why the CI failed. Since this was a single commit, I just fixed the commit message when squash-merging to:

-googleauth: newline was being eaten
+fix(googleauth): ensure newline is preserved in `repl` of `file.replace`

Tested this fix locally using Kitchen.

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 0.48.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: