search

saltstack-formulas / vault-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
15 stars 59 forks source link

feat(freebsd): add FreeBSD support #32

Closed Strade28 closed 3 years ago

dafyddj commented 5 years ago

The changes seem fine to me, but could do with being tested, no? (By which I mean adding a platform to test-kitchen)

Strade27 commented 5 years ago

Hello, unfortunetly travis doesn’t support freebsd. I not found easy way to do that.

dafyddj commented 5 years ago

You could add a custom kitchen.yml, and leave it out from Travis. A manual test is better than no test, IMO.

myoung34 commented 5 years ago

Manual tests are generally fine but they wont be run because maintainers just rely on the GH status API.

If the tests that are in place work, then the code is fine as-is, and if it works with FreeBSD then thats a bonus until travis supports that platform. Until then this is just a refactor change and freebsd is unofficially supported as far as tests/assertions are concerned

Strade28 commented 5 years ago

Hello ! I add some local test for freebsd using kitchen-vagrant.

rbjorklin commented 5 years ago

Just a heads up that my change that just got merged might have broken this. https://github.com/saltstack-formulas/vault-formula/pull/33

Strade28 commented 5 years ago

Just a heads up that my change that just got merged might have broken this.

33

Thanks ! there is not problem with your change.

n-rodriguez commented 5 years ago

there is an issue in dev-server-freebsd-11 converge step :

I, [2019-06-24T14:56:15.130479 #16838]  INFO -- dev-server-freebsd-11:           ID: vault-service-init-service-running
I, [2019-06-24T14:56:15.130565 #16838]  INFO -- dev-server-freebsd-11:     Function: service.running
I, [2019-06-24T14:56:15.130695 #16838]  INFO -- dev-server-freebsd-11:         Name: vault
I, [2019-06-24T14:56:15.130781 #16838]  INFO -- dev-server-freebsd-11:       Result: False
I, [2019-06-24T14:56:15.130866 #16838]  INFO -- dev-server-freebsd-11:      Comment: Service vault has been enabled, and is dead
I, [2019-06-24T14:56:15.130948 #16838]  INFO -- dev-server-freebsd-11:      Started: 12:56:13.567798
I, [2019-06-24T14:56:15.131029 #16838]  INFO -- dev-server-freebsd-11:     Duration: 372.742 ms
I, [2019-06-24T14:56:15.131112 #16838]  INFO -- dev-server-freebsd-11:      Changes:   
I, [2019-06-24T14:56:15.131202 #16838]  INFO -- dev-server-freebsd-11:        ----------
I, [2019-06-24T14:56:15.131291 #16838]  INFO -- dev-server-freebsd-11:        vault:
I, [2019-06-24T14:56:15.131381 #16838]  INFO -- dev-server-freebsd-11:            True

dev-server-freebsd-11.log

myii commented 5 years ago

@Strade28 The following is a suggestion, not a requirement:

Basically, leave Travis CI as-is but add a single entry for FreeBSD in Cirrus CI.

fzipi commented 5 years ago

@Strade28 Can you solve the conflicts so this can be merged?

myii commented 5 years ago

@aboe76 Can we add @dafyddj to the SaltStack Formulas contributors group? Thanks in advance.

aboe76 commented 5 years ago

If @dafyddj sends an invite I can aprove it.

dafyddj commented 5 years ago

If @dafyddj sends an invite I can aprove it.

I can't invite myself, surely?

aboe76 commented 5 years ago

@dafyddj try this page: https://github.com/orgs/saltstack-formulas/teams

aboe76 commented 5 years ago

@UtahDave can you invite @dafyddj ?

myii commented 5 years ago

@aboe76 How about this?

aboe76 commented 5 years ago

@myii yes I know but I don't have access, I'm only a moderator.

myii commented 3 years ago

@Strade28 We've finally got FreeBSD Vagrant testing working in GitHub Actions but unfortunately that's come a bit too late for this PR -- I wasn't able to push the changes here since your fork is no longer available. However, I've recovered your excellent contribution and added the CI on top in #54. I had to squash your commits and do a bit of jiggling but the backbone of your work is all there.

Thanks to all of the others for their comments and reviews towards this PR.

Closing this PR since nothing else can be done here. Please continue any further discussion in #54.

myii commented 2 years ago

@Strade28 #54 has been merged, so the work in this PR wasn't lost in the end -- thanks again for the contribution.