search

saltstack-formulas / vault-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
15 stars 59 forks source link

ci: merge travis matrix, add `salt-lint` & `rubocop` to `lint` job #49

Closed myii closed 4 years ago

myii commented 4 years ago

@dafyddj I've rolled this out as one of the first conversions, so that we minimise delays for #48. Note that this involved fixing one file to get salt-lint passing:

[204] Lines should be no longer that 160 chars
vault/files/cert-gen.sh.j2:34
root_subj="/C={{ vault.self_signed_cert.country }}/ST={{ vault.self_signed_cert.state }}/L={{ vault.self_signed_cert.city }}/O={{ vault.self_signed_cert.org }}/OU={{ vault.self_signed_cert.org_unit }}/CN=$root\_ca"

[204] Lines should be no longer that 160 chars
vault/files/cert-gen.sh.j2:75
child_subj="/C={{ vault.self_signed_cert.country }}/ST={{ vault.self_signed_cert.state }}/L={{ vault.self_signed_cert.city }}/O={{ vault.self_signed_cert.org }}/OU={{ vault.self_signed_cert.org_unit }}/CN=$child_name"

Otherwise, as I mentioned in https://github.com/saltstack-formulas/template-formula/pull/175#issuecomment-539719665, we're using allow_failures on the separate rubocop lint job.

myii commented 4 years ago

You're welcome, they were good suggestions! Thanks for the merge.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.2.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: