search

saltstack-formulas / vault-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
15 stars 59 forks source link

ci(kitchen+travis): use bootstrapped `amazonlinux-1` images #50

Closed myii closed 4 years ago

myii commented 4 years ago

@dafyddj Needed amazonlinux-1 for the epel-formula so took this opportunity to standardise the way bootstrapped images are provided by the ssf-formula. Up to now, it's been using an inline if block solely for the vault-formula; now it can provide amazonlinux-1 to formulas in the same way as pre-salted images.

I've tested all of these across all three suites (and the combined one) here:

myii commented 4 years ago

@dafyddj Nope, let's not merge this just yet, after your excellent feedback. That's got me wondering, though: when is the right time to use the provisioner? Surely there must be some reason for having that feature; are you aware of what that might be? As far as I can recall, most/all of the formulas were using this rather than the provision_command, before we started work on all of this standardisation.

myii commented 4 years ago

My initial test related to this PR appear to confirm this.

dafyddj commented 4 years ago

Surely there must be some reason for having that feature; are you aware of what that might be?

The speed difference is very specific to Docker and the way it builds up an image from cached layers. Another driver such as kitchen-vagrant wouldn't see the speed increase, and so either method could be used, so I think this is just a case of "there's more than one way to do it" - some ways turn out better than others.

Also, the use of pre-Salted images made this issue largely irrelevant.

myii commented 4 years ago

@dafyddj Of course, kitchen-vagrant and other provisioners, thanks for reminding me of that.

I'll make the adjustments in the ssf-formula and then finalise this PR, probably within the next day.

myii commented 4 years ago

@dafyddj I've updated this PR. I've also applied these changes to https://github.com/saltstack-formulas/epel-formula/pull/55. Would you mind merging these?

myii commented 4 years ago

Merging since already confirmed essentially.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 1.2.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: