feat: allow install_from_repo

ze42 commented 2 years ago

Vault debian repo added as an option

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[x] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Support install from (hashicorp) repo - with proper defaults for Debian

Pillar / config required to test the proposed changes

vault:
  install_from_repo: True
  version: none  # Or any valid recent version, or latest to force latest version upgrade

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[x] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

ze42 commented 2 years ago

Any hint on how to write specific tests for those?

dafyddj commented 2 years ago

Hi, thanks for your contribution. Let me take a couple of days to take a look at this.

ze42 commented 2 years ago

@dafyddj had you any time in the last months?

dafyddj commented 1 year ago

Hi, sorry for the long delay. Can you rebase this PR and push to re-run the tests?

mdschmitt commented 1 year ago

Is there a status update on this?

saltstack-formulas / vault-formula