salt_install=distrib don't work for non debian based hosts

[philpep]

Hi,

I use this .kitchen.yml file

driver:
  name: vagrant

platforms:
  - name: debian-9
  - name: centos-7

provisioner:
  name: salt_solo
  salt_install: distrib

and it looks like distrib fails to install salt-minion on centos hosts because it try to install using apt-get

$ kitchen converge centos-7
-----> Starting Kitchen (v1.23.2)                                                      
-----> Converging <default-centos-7>...                                                
       Preparing files for transfer                                                               
       Preparing salt-minion                                                           
       Preparing pillars into /srv/pillar                                              
       Preparing state collection                                                      
       neither collection_name or formula have been set, assuming this is a pre-built collection
       Preparing state_top                                                                            
       Preparing scripts into /etc/salt/scripts                                                  
       sudo: apt-get: command not found                                                
       sudo: apt-get: command not found                                                       
       No salt-minion installed, install must have failed!!                                      
       salt_install = distrib                                                                                                                  
       salt_url = https://bootstrap.saltstack.com                                              
       bootstrap_options =                                                                     
       salt_version = latest                                                                    
       salt_apt_repo = https://repo.saltstack.com/apt/ubuntu/16.04/amd64/               
       salt_apt_repo_key = https://repo.saltstack.com/apt/ubuntu/16.04/amd64/latest/SALTSTACK-GPG-KEY.pub
       salt_ppa = ppa:saltstack/salt                                                   
       salt_yum_rpm_key = https://repo.saltstack.com/yum/redhat/7/x86_64/archive/latest/SALTSTACK-GPG-KEY.pub
       salt_yum_repo = https://repo.saltstack.com/yum/redhat///archive/latest                                             
       salt_yum_repo_key = https://repo.saltstack.com/yum/redhat///archive/latest/SALTSTACK-GPG-KEY.pub
       salt_yum_repo_latest = https://repo.saltstack.com/yum/redhat/salt-repo-latest-2.el7.noarch.rpm
>>>>>> ------Exception-------                                                          
>>>>>> Class: Kitchen::ActionFailed                                                    
>>>>>> Message: 1 actions failed.                                                      
>>>>>>     Converge failed on instance <default-centos-7>.  Please see .kitchen/logs/default-centos-7.log for more details
>>>>>> ----------------------                                                           
>>>>>> Please see .kitchen/logs/kitchen.log for more details                         
>>>>>> Also try running `kitchen diagnose --all` for configuration

[gtmanfred]

:+1: yeah this is a bug, but i don't really have any interest in fixing it, because the distributed versions are years old.

[   ] salt-2015.5.10-2.el7.noarch.rpm                          2016-06-01 07:45  4.1M  
[   ] salt-api-2015.5.10-2.el7.noarch.rpm                      2016-06-01 07:45   13K  
[   ] salt-cloud-2015.5.10-2.el7.noarch.rpm                    2016-06-01 07:45   16K  
[   ] salt-master-2015.5.10-2.el7.noarch.rpm                   2016-06-01 07:45  1.0M  
[   ] salt-minion-2015.5.10-2.el7.noarch.rpm                   2016-06-01 07:45   26K  
[   ] salt-ssh-2015.5.10-2.el7.noarch.rpm                      2016-06-01 07:45   15K  
[   ] salt-syndic-2015.5.10-2.el7.noarch.rpm                   2016-06-01 07:45   13K  

And are unsupported now. Installing from repo.saltstack.com is the recommended way, either by using yum or the bootstrap method.

I would accept a PR to implement this though.