libnacl should support libsodium 23

[aboe76]

ibnacl cannot use libsodium.so.23, /libnacl/init.py should be modified to for libsodium.so.23. Adding 23 to the __SONAMES array on line 12 should be the simplest fix.

[dmurphy18]

@aboe76 It would be helpful to know the version of Salt and platform that you are running, can you run the following and return the results: salt-run --versions-report

[aboe76]

Salt Version:
           Salt: 2018.3.0

Dependency Versions:
           cffi: 1.11.5
       cherrypy: Not Installed
       dateutil: 2.6.1
      docker-py: 3.4.1
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.10
        libgit2: 0.27.0
        libnacl: 1.6.1
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: 2.18
       pycrypto: 3.6.3
   pycryptodome: Not Installed
         pygit2: 0.27.0
         Python: 3.6.5 (default, Mar 31 2018, 19:45:04) [GCC]
   python-gnupg: Not Installed
         PyYAML: 3.13
          PyZMQ: 17.1.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: 0.2.4
        Tornado: 4.5.3
            ZMQ: 4.2.5

System Versions:
           dist:   
         locale: UTF-8
        machine: x86_64
        release: 4.17.9-1-default
         system: Linux
        version: Not Installed

libsodium:

rpm -qa|grep libsodium
2885:libsodium23-1.0.16-3.1.x86_64

[dmurphy18]

@aboe76 Unfortunately the platform did not come through in the dist: field. Can you provide the Operating system and version, for example: cat /etc/redhat-release (Redhat) or lsb_release -a (Debian/Ubuntu).

[aboe76]

@dmurphy18

cat /etc/os-release 
NAME="openSUSE Tumbleweed"
# VERSION="20180726"
ID="opensuse-tumbleweed"
ID_LIKE="opensuse suse"
VERSION_ID="20180726"
PRETTY_NAME="openSUSE Tumbleweed"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:tumbleweed:20180726"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"

[dmurphy18]

@aboe76 SaltStack does not build the SUSE packages, those come from SUSE. They are available from repo.saltstack.com but that is a courtesy and they are mirrored from SUSE's repositories. A possible contact point would be Klaus Kaempf kkaempf@suse.de.

Will look into updating Redhat 7 packages from SaltStack to utilize a later version of libsodium in the next point release, see https://github.com/saltstack/salt-pack/issues/573.

[aboe76]

@dmurphy18 thanks, I know Klaus Kaempf, I helped with building the first batch of salt packages on suse/opensuse. I still package maintain some libraries, which include libnacl.

[dmurphy18]

@aboe76 Given that the issue is in the hands of SUSE, can you close this issue. Salt is already using libsodium.so.23 for Redhat 7, as in Salt 2018.3.2

[aboe76]

@dmurphy18, if that is the case why isn't the source updated to reflect this....

[dmurphy18]

@aboe76 Salt and its dependencies are build from git repo's salt-pack for Python 2, and salt-pack-py3 for Python 3. The version of libsodium is determined by the highstate used to build Salt and libsodium, for example: for Redhat 7 https://github.com/saltstack/salt-pack/blob/8ab27ec29163a1e2fa72bc29e984a09c44f44077/file_roots/versions/2018_3_2/redhat_pkg.sls#L6. It is the version built with rather than any declaration in Salt spec file. This is due to dependencies and their versions changing depending on the version of the OS and the platform built on.

Understanding that SUSE appear to include all possible dependencies in their spec files for building Salt,, for example: raet. A method that has been adversely commented in some Redhat/Fedora forums in the past.

[aboe76]

@dmurphy18 thanks for your explanation will try to fix it opensuse buil service.