search

saltstack / pepper

A library and stand-alone CLI tools to access a salt-api instance
Other
247 stars 124 forks source link

Add empty jid reply processing #142

Closed ezh closed 6 years ago

ezh commented 6 years ago

Related to #141

gtmanfred commented 6 years ago

Can you give me more information on what the goal here is?

If you want it to use poll_for_return, then you should be passing in --fail-if-incomplete

gtmanfred commented 6 years ago

What is happening here looks like it ends up calling the same api call over and over again if it gets that jid return, which is not desirable.

ezh commented 6 years ago

This PR use pepper option -t TIMEOUT, --timeout=TIMEOUT Specify wait time (in seconds) before returning control to the shell

gtmanfred commented 6 years ago

Overall I think this is a good idea, but I would really like to have it be opt-in, instead of the default.

Something they have to say, I want to run async, and automatically query for the results in the job database

ezh commented 6 years ago

Yep. It is up to you. It looks that I just changed behaviour, not fix the issue.

gtmanfred commented 6 years ago

I am going to leave this PR as closed.

But am still interested in trying to fix the issue that you opened.