search

saltstack / salt-bootstrap

Generic Salt Bootstrap Script
Other
928 stars 549 forks source link

Consider raising minimal apache-libcloud version to 2.0.0 #1290

Closed max-arnold closed 5 years ago

max-arnold commented 6 years ago

Description of Issue/Question

salt/modules/libcloud_*.py depend on apache-libcloud>=2.0.0, so please consider bumping the pinned version number from 0.14.0 https://github.com/saltstack/salt-bootstrap/blob/develop/bootstrap-salt.sh#L253.to 2.0.0 https://github.com/saltstack/salt/blob/develop/salt/modules/libcloud_dns.py#L43

See https://github.com/saltstack/salt/pull/50296#pullrequestreview-169774921 for more details.

rallytime commented 6 years ago

Hi @max-arnold - There are other files in Salt that depend on the 0.14 version see here.

I hesitate to increase the minimum version without knowing what that effect that will have on the cloud-providers that use the libcloudfuncs.py file in salt.

Furthermore, the _LIBCLOUD_MIN_VERSION="0.14.0" shouldn't be a pinned version, but a minimum version. We check for a >= value. So if a newer version is available to install via pip, then that will be installed over the minimum.

max-arnold commented 5 years ago

I guess it makes no sense to leave this issue open.