saltstack / salt-bootstrap

Generic Salt Bootstrap Script
Other
928 stars 550 forks source link

Adding support for Ubuntu newer versions (22.04 -> 24.xx) #1914

Closed compi-tom closed 1 year ago

compi-tom commented 1 year ago

What does this PR do?

Reviewing the conditions from __install_saltstack_ubuntu_repository():

  1. Versions >20.04 & <22.04 use the focal repo with the already existing warning about non LTS
  2. Ubuntu 22.04/Jammy use the default as the repo is available
  3. Version > 22.04 to 24.xx use the jammy repo

What issues does this PR fix or reference?

https://github.com/saltstack/salt-bootstrap/issues/1905

Previous Behavior

Bootstraping saltstack on Ubuntu 22.04 (LTS) resulted in using focal repo.

New Behavior

Bootstraping saltstack on Ubuntu 22.04 (LTS) use the jammy repo.

timwsuqld commented 1 year ago

@compi-tom why was this closed? This is needed for issue #1915

compi-tom commented 1 year ago

@timwsuqld as stated in saltstack documentation the installation method will be switched to onedir only starting v3006. The bootstrap script is already working fine with ubuntu 22.04 using the onedir argument. As I was adding all the changes and specific cases I started to think that it's kinda pointless to add the legacy support.