search

saltstack / salt-bootstrap

Generic Salt Bootstrap Script
Other
926 stars 545 forks source link

WIP: fix nightlys (incorrect old repo path) #1951

Open ITJamie opened 1 year ago

ITJamie commented 1 year ago

What does this PR do?

Add testing of nightly build installs to catch issues with gpg logic etc

ive just noticed that the nightly paths are wrong. they should be using:

but are using:

the items in the second path are old (from feb)

ITJamie commented 1 year ago

hmm. im struggling to figure out the logic for the debian/ubuntu nightlys.

https://repo.saltproject.io/salt-dev/master/latest/salt/py3/debian/10/amd64/minor/ there's a dir inside with a random build name.

the rhel based ones have a mirror.repo inside the minor folder to point to build name, the debian and ubuntu ones do not...

I've brought it in the releases slack channel. a "latest" symlink pointer inside "minor" would be useful for this https://saltstackcommunity.slack.com/archives/C01R6B3CGAD/p1690071708455759

ITJamie commented 1 year ago

blocked by https://github.com/saltstack/salt/issues/64700.

ITJamie commented 1 year ago

blocked by https://github.com/saltstack/salt/issues/64927

ITJamie commented 8 months ago

blocked by: https://github.com/saltstack/salt/issues/65877

dmurphy18 commented 2 months ago

@ITJamie Are you still interested in this PR. The current release 2024-07012 has cleaned up a lot of the old cruff and wondering if still interested in doing this PR, if not, please consider closing it.

ITJamie commented 2 months ago

Im happy to rework it but theres still no upstream latest repo symlink to be able to sanely deploy repofiles with a fixed symlink path

dmurphy18 commented 2 months ago

@ITJamie Have the following for nightly builds of Salt,

There is also the nightly workflow in GitHub Actions https://github.com/saltstack/salt/actions/workflows/nightly.yml, if that helps

mgeggie commented 2 months ago

Would really like to see this PR merged as soon as possible. We have a Packer build that just broke while attempting to bootstrap Salt 3005 on Ubuntu 22.04, due to a mis-matched path in the script looking for SALT-PROJECT-GPG-PUBKEY-2023.gpg in our exact version distribution directory (https://repo.saltproject.io/salt/py3/ubuntu/22.04/amd64/minor/3005/SALT-PROJECT-GPG-PUBKEY-2023.gpg) instead of in https://repo.saltproject.io/salt/py3/ubuntu/22.04/amd64/SALT-PROJECT-GPG-PUBKEY-2023.gpg.