search

saltstack / salt-bootstrap

Generic Salt Bootstrap Script
Other
929 stars 547 forks source link

cleanup old information in the README.rst file #1955

Closed garethgreenaway closed 10 months ago

garethgreenaway commented 11 months ago

What does this PR do?

cleanup old information in the README.rst file

ITJamie commented 11 months ago

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

s0undt3ch commented 11 months ago

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

ITJamie commented 11 months ago

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

.github/workflows/scripts/update-release-shasum.py builds the actual readme.md file from the rst. a string replacement can be done here to always set the version number to the latest version (checking the salt repo as a reference i guess)

s0undt3ch commented 10 months ago

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

.github/workflows/scripts/update-release-shasum.py builds the actual readme.md file from the rst. a string replacement can be done here to always set the version number to the latest version (checking the salt repo as a reference i guess)

Well, that does sound like a suggestion that is not impossible to implement.

@garethgreenaway thoughts?

garethgreenaway commented 10 months ago

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

.github/workflows/scripts/update-release-shasum.py builds the actual readme.md file from the rst. a string replacement can be done here to always set the version number to the latest version (checking the salt repo as a reference i guess)

Well, that does sound like a suggestion that is not impossible to implement.

@garethgreenaway thoughts?

@s0undt3ch Woks for me.

s0undt3ch commented 10 months ago

would it be worth having a substitution var in the rst file instead of declaring the explicit 3006.1 number over and over?

How would that render in GitHub?

.github/workflows/scripts/update-release-shasum.py builds the actual readme.md file from the rst. a string replacement can be done here to always set the version number to the latest version (checking the salt repo as a reference i guess)

Well, that does sound like a suggestion that is not impossible to implement. @garethgreenaway thoughts?

@s0undt3ch Woks for me.

@ITJamie if you want to take a stab at it, we would be happy to review it.