search

saltstack / salt-bootstrap

Generic Salt Bootstrap Script
Other
928 stars 551 forks source link

fix almalinux #2055

Closed jeff350 closed 11 hours ago

jeff350 commented 1 day ago

What does this PR do?

In the most recent release (2024.11.21) the almalinux install functions were renamed to rockylinux, however the necessary rocky_linux functions already existed for Rockylinux (see next section in code). The rename of these functions broke the ability for almalinux installs to work. This PR renames the functions back to almalinux so that bootstrap will again work on both almalinux and rockylinux.

What issues does this PR fix or reference?

Previous Behavior

Bootstrap is broken on almalinux after 2024.11.21 release

New Behavior

Installs work on both rockylinux and almalinux

dmurphy18 commented 11 hours ago

@jeff350 Not going to happen, Rocky Linux -> Alma Linux, as I stated previously, Rocky Linux is the now designated testing platform for RedHat families and that decision was made summer of 2024.

However, I will add the AlmaLinux back in to since it is causing problems, which was not the intent. Thought it would finally default into using Centos the way that Rocky Linux does.

Working on git install issues with Rocky Linux 9, and will add the AlmaLinux support back in, in addition to Rocky Linux, similar to your PR. Cannot give timeline, since working on git install and when it passes testing.

Closing this PR as a result, but feel free to re-open if there is additional information.

dmurphy18 commented 11 hours ago

See my PR https://github.com/saltstack/salt-bootstrap/pull/2057 for your changes implemented in conjunction with Rocky Linux

jeff350 commented 10 hours ago

@dmurphy18 please take a closer look at this PR. This already contains both the rocky and almaLinux functions as you are stating is needed, and I agree.

The PR you reference renamed the almalinux functions to rockylinux, This change was not necessary as the rocky_linux functions (with underscore) already existed. See line 5220 in PR #2057. After the 2024.11.21 release both rocky_linux and rockylinux functions exist. the rockylinux functions are not used or needed. This PR renames the functions back to almalinux to restore bootstrap's ability to work on both rocky and almalinux as was supported in v2024.11.07.

dmurphy18 commented 9 hours ago

@jeff350 That is what I did renamed the rockylinux back to almalinux