saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here:
https://repo.saltproject.io/
Apache License 2.0
14.16k stars 5.48k forks source link

Comment about missing requisite adding unnecessary newlines #25735

Closed scott-edwards-123 closed 6 years ago

scott-edwards-123 commented 9 years ago

This is a small issue but I thought it looks like an error that should be documented. Version: 2014.7.1 (Helium) OS: CentOS 6

Note how in the first report of this missing requisite everything is laid out properly.

 Comment: The following requisites were not found:
                             require:
                                 file: ambari.properties

Then in the second mention of it, it starts to add what appears to be a newline; "\n" and the text isn't laid out properly.

 Comment: One or more requisite failed: {'abc.hadoop.abc-hadoop-ambari-server.ambari-setup-script': 'The following requisites were not found:\n                   require:\n                       file: ambari.properties\n'}

Then in the third mention of it, it adds a second slash in front of the newline; "\n".

 Comment: One or more requisite failed: {'abc.hadoop.abc-hadoop-ambari-server.run-ambari-setup': "One or more requisite failed: {'abc.hadoop.abc-hadoop-ambari-server.ambari-setup-script': 'The following requisites were not found:\\n                   require:\\n                       file: ambari.properties\\n'}"}

Excerpt Below

      ID: ambari-setup-script
Function: file.managed
    Name: /usr/local/abc-automation/scripts/ambari-setup.sh
  Result: False
 Comment: The following requisites were not found:
                             require:
                                 file: ambari.properties
 Started:
Duration:
 Changes:

      ID: run-ambari-setup
Function: cmd.run
    Name: /usr/local/abc-automation/scripts/ambari-setup.sh
  Result: False
 Comment: One or more requisite failed: {'abc.hadoop.abc-hadoop-ambari-server.ambari-setup-script': 'The following requisites were not found:\n                   require:\n                       file: ambari.properties\n'}
 Started:
Duration:
 Changes:

      ID: start-ambari-server
Function: service.running
  Result: False
 Comment: One or more requisite failed: {'abc.hadoop.abc-hadoop-ambari-server.run-ambari-setup': "One or more requisite failed: {'abc.hadoop.abc-hadoop-ambari-server.ambari-setup-script': 'The following requisites were not found:\\n                   require:\\n                       file: ambari.properties\\n'}"}
 Started:
Duration:
 Changes:
jfindlay commented 9 years ago

@edwardsgs, thanks for the report. Does this also happen on 2015.5.3?

scott-edwards-123 commented 9 years ago

I haven't been able to try the new version yet.

On 27 July 2015 at 11:14, Justin Findlay notifications@github.com wrote:

@edwardsgs https://github.com/edwardsgs, thanks for the report. Does this also happen on 2015.5.3?

— Reply to this email directly or view it on GitHub https://github.com/saltstack/salt/issues/25735#issuecomment-125241235.

-Scott

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.