saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here:
https://repo.saltproject.io/
Apache License 2.0
14.17k stars 5.48k forks source link

Feature request: filesystem label support for blockdev.formatted #33857

Open Talkless opened 8 years ago

Talkless commented 8 years ago

Description of Issue/Question

mkfs.ext4 and mkfs.xfs has -L option to set human readable file system label. Though blockdev.formatted accepts kwargs, blockdev.format execution module does not currently have ability to set label.

Ch3LL commented 8 years ago

@Talkless I think this is a sound idea to add this feature. Thanks

shallot commented 7 years ago

I seem to have run across this issue - I'm trying to get some file systems formatted with specific labels, but blockdev.formatted provides no apparent option to specify a label that would in turn be passed down to the mkfs function.

dhs-rec commented 6 years ago

In addition to this, it would also be great to support passing arbitrary options to the various mkfs tools. For example, I currently need to use a cmd.run to format an XFS filesystem because neither -L nor -f are supported by blockdev.formatted:

format_device:
  cmd.run:
    - name: mkfs.xfs -f -LDOCKER /dev/{{ storage_dev }}
    - unless: blkid -p -n xfs /dev/{{ storage_dev }}|grep xfs
mruepp commented 6 years ago

Is there still no way to pass arguments to blockdev.formatted?

Ch3LL commented 6 years ago

No but we are always willing to accept PRs :)

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

Talkless commented 5 years ago

Ping.

stale[bot] commented 5 years ago

Thank you for updating this issue. It is no longer marked as stale.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

dhs-rec commented 4 years ago

And another ping.

stale[bot] commented 4 years ago

Thank you for updating this issue. It is no longer marked as stale.