search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Install Salt from the Salt package repositories here:
https://docs.saltproject.io/salt/install-guide/en/latest/
Apache License 2.0
14.19k stars 5.48k forks source link

Suggestion: salt-bootstrap use master version for minion version if master is configured #42478

Open aikar opened 7 years ago

aikar commented 7 years ago

Description of Issue/Question

let me preface I understand the salt-cloud is not part of the salt-master, and can be used without a master.

During minion provisioning, if a master is configured to be set for this minion, and a version is not already being supplied to the salt-bootstrap command, then I suggest that salt-bootstrap file reaches out to the master to determine it's version, and automatically use that version.

Before discovering how to define minion version using script/script_args for the salt-cloud provider, minions being installed as latest before we had the chance to update the master has caused numerous problems, and I am sure it has hit many more than us.

If the salt-bootstrap has version supplied, then obviously this logic should not engage. It should occur when no version has been supplied, and try to synchronize with master if a master exists, else use latest.

gtmanfred commented 7 years ago

That is a great idea, I am marking it as a feature request.

If you have time, would you mind submitting a PR to the develop branch to implement this feature (if you do, please also include a note in the release documentation for the Oxygen release)

Thanks, Daniel

aikar commented 7 years ago

Sorry I do not know python, nor time to learn it, to do this myself.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

gtmanfred commented 6 years ago

this would take minimal effort to add and would fit the guidelines for salt-cloud, the default version that should be used for bootstrapping is the same version of salt that salt-cloud is.

@saltstack/team-triage

stale[bot] commented 6 years ago

Thank you for updating this issue. It is no longer marked as stale.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

aikar commented 4 years ago

Unless this has already been done, this is absolutely something that should remain open and be done.

stale[bot] commented 4 years ago

Thank you for updating this issue. It is no longer marked as stale.