Closed timwsuqld closed 10 months ago
@timwsuqld Thanks for the report. Was this working correctly in 2018.3.x?
@garethgreenaway I'm not sure if it was working on 2018.3.x. I was writing new states and couldn't get it working, we upgraded to 2019.2 a few weeks back, so never tried it on 2018.3.
Thanks
@timwsuqld No worries. Just wanted to determine if it was something that broke with the 2019.2.0 release or if it was broken in 2018.3 as well. Thanks! :smile:
number_of_inodes
has the same issue, and I would assume that many other mkfs options are being silently ignored as well.
Not quite sure why this issue status is blocked
because this is in one piece of source code, I assume the fix is reasonably straightforward (but no I have not tried)
Description of Issue/Question
When using state
module.run
to call theextfs.mkfs
it's not passing thelabel
argument through.Setup
Steps to Reproduce Issue
Run state.sls expecting it to format
/dev/disk/by-id/scsi-0Google_PersistentDisk_borg-repository
with the label "Borg-Repository-label", the format works but the label is not set.Below are snipped debug logs. In that run, I also had m_label set to see if that worked, and there is a second mount state that follows the format state. The OrderedDict clearly has label as a parameter, but it's not passed to mke2fs.
Running the module directly instead of the state shows that label is correctly used, so it's something to do with module.run not passing things correctly, but I can't see in the code where the problem is.
Versions Report
Client is Ubuntu 18.04, master is 16.04 still. But both on 2019.2.0 salt.