search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Install Salt from the Salt package repositories here:
https://docs.saltproject.io/salt/install-guide/en/latest/
Apache License 2.0
14.18k stars 5.48k forks source link

[BUG] chocolatey upgrade forces install even if package is already installed and force is false #57894

Open adamsewell opened 4 years ago

adamsewell commented 4 years ago

Description When running the chocolatey upgrade module command, if a package is already installed, the package is reinstalled not skipped. I'm testing with the saltminion package. Even including the force=False still reinstalls the package.

Setup salt 'minion' chocolatey.upgrade 'saltminion'

Steps to Reproduce the behavior

  1. run salt 'minion' chocolatey.upgrade 'saltminion'
  2. verify package is installed and upgraded with salt 'minion' test.version
  3. run salt 'minion' chocolatey.upgrade 'saltminion' again and the package is reinstalled

Expected behavior To skip installation of the same version of the package

Versions Report

salt --versions-report (Provided by running salt --versions-report. Please also mention any differences in master/minion versions.) ``` Salt Version: Salt: 3000.3 Dependency Versions: cffi: Not Installed cherrypy: Not Installed dateutil: 2.6.1 docker-py: Not Installed gitdb: 2.0.3 gitpython: 2.1.8 Jinja2: 2.10 libgit2: Not Installed M2Crypto: Not Installed Mako: 1.0.7 msgpack-pure: Not Installed msgpack-python: 0.5.6 mysql-python: Not Installed pycparser: Not Installed pycrypto: 2.6.1 pycryptodome: Not Installed pygit2: Not Installed Python: 2.7.17 (default, Apr 15 2020, 17:20:14) python-gnupg: 0.4.1 PyYAML: 3.12 PyZMQ: 16.0.2 smmap: 2.0.3 timelib: Not Installed Tornado: 4.5.3 ZMQ: 4.2.5 System Versions: dist: Ubuntu 18.04 bionic locale: UTF-8 machine: x86_64 release: 4.15.0-109-generic system: Linux version: Ubuntu 18.04 bionic ```
sagetherage commented 4 years ago

@krionbsd can you verify this packaging issue, please?

sagetherage commented 4 years ago

@cmcmarrow can you verify this issue, please?