search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Install Salt from the Salt package repositories here:
https://docs.saltproject.io/salt/install-guide/en/latest/
Apache License 2.0
14.22k stars 5.49k forks source link

Need fix the service control script of in Suse #5954

Closed puluto closed 11 years ago

puluto commented 11 years ago

In service salt-master or minion reload "rc status -v" need change to "rc_status -v" in the /salt-develop/pkg/suse/salt-master and salt-minion

The status check need add "RETVAL=$?" append "rc_status -v" if system is SUSE, because the service did stopped, the exit code still is '0', then salt service.status salt-minion or salt-master can't get correct results

terminalmage commented 11 years ago

Confirmed, thanks for the report. Fixed in https://github.com/saltstack/salt/pull/5967.

@aboe76 can you patch the salt-master and salt-minion initscripts and update the suse packages for 0.16.0?

aboe76 commented 11 years ago

I will do it this weekend

terminalmage commented 11 years ago

Thanks!

aboe76 commented 11 years ago

@puluto thanks, for catching my error, I will fix this and release a updated 0.16.0 package

terminalmage commented 11 years ago

Note that this has already been fixed in git, it just needs to be fixed in the rpm.

terminalmage commented 11 years ago

I've also ported this fix to the bugfix branch, so it will be there for any bugfix releases.

aboe76 commented 11 years ago

I saw it, and updated build.opensuse.org accordingly, If it is possible could the init scripts be tested on fedora/redhat?? They should be working also...

If they work, we could symlink the init and systemd files for these distributions. At a later date, we could merge the spec files, into one

2013/7/5 Erik Johnson notifications@github.com

Note that this has already been fixed in git, it just needs to be fixed in the rpm.

— Reply to this email directly or view it on GitHubhttps://github.com/saltstack/salt/issues/5954#issuecomment-20539740 .

aboe76 commented 11 years ago

Done all packages are rebuild with fix initscript

terminalmage commented 11 years ago

Thanks @aboe76!

aboe76 commented 11 years ago

No problem, opensuse.buildservice is slow this weekend.otherwise it was done yesterday

2013/7/6 Erik Johnson notifications@github.com

Thanks @aboe76 https://github.com/aboe76!

— Reply to this email directly or view it on GitHubhttps://github.com/saltstack/salt/issues/5954#issuecomment-20559624 .