search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here:
https://repo.saltproject.io/
Apache License 2.0
14.15k stars 5.48k forks source link

[BUG] SleekXMPP should be replaced with slixmpp #60354

Open ari opened 3 years ago

ari commented 3 years ago

The slixmpp project has replaced the now deprecated SleekXMPP. See the notice here: https://github.com/fritzy/SleekXMPP

On the plus side, the new library should be just drop in with only import changes.

sagetherage commented 3 years ago

@cmcmarrow let's put in a deprecation warning in and then get an estimate of LOE level of effort for the new library. Warning can go in right away, but need to get an idea of LOE before we can implement the replacement and plan for it in a release. Let's do the planning in Silicon release cycle.

ari commented 3 years ago

Is it clear that anything user facing needs to be deprecated, other than ensuring the user puts the correct library into the python classpath?

cmcmarrow commented 3 years ago

@sagetherage slixmpp API looks to be the same "took a 30 sec look". If that is true we should try to import it and then import the older module, as well add the deprecation warning.

cmcmarrow commented 3 years ago

https://github.com/fritzy/SleekXMPP repository has been archived AKA it is no long maintained as of NOW.

sagetherage commented 3 years ago

@cmcmarrow yes - level of effort is needed, given all the other priorities for the current release cycle