search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here:
https://repo.saltproject.io/
Apache License 2.0
14.08k stars 5.47k forks source link

[BUG] [onedir] cmd.run runas cannot get environment #62565

Closed d--j closed 1 year ago

d--j commented 2 years ago

Description cmdmod.run uses sys.executable to execute some dynamic Python code to get the environment of the user the command should run as. See https://github.com/saltstack/salt/blob/4bbdd653676de8734fabca68adfda023ad0f0e0d/salt/modules/cmdmod.py#L524-L535

This does not work in tiamat / onedir installations since sys.executable is /opt/saltstack/salt/run/run and /opt/saltstack/salt/run/run cannot handle piped in Python code.

Steps to Reproduce the behavior

Expected behavior No error message. Salt is able to pick up the environment variables defined for the user.

Versions Report

salt --versions-report (Provided by running salt --versions-report. Please also mention any differences in master/minion versions.) ```yaml Salt Version: Salt: 3005 Dependency Versions: cffi: 1.14.6 cherrypy: unknown dateutil: 2.8.1 docker-py: Not Installed gitdb: Not Installed gitpython: Not Installed Jinja2: 3.1.0 libgit2: Not Installed M2Crypto: Not Installed Mako: Not Installed msgpack: 1.0.2 msgpack-pure: Not Installed mysql-python: Not Installed pycparser: 2.21 pycrypto: Not Installed pycryptodome: 3.9.8 pygit2: Not Installed Python: 3.9.13 (main, Aug 23 2022, 18:31:04) python-gnupg: 0.4.8 PyYAML: 5.4.1 PyZMQ: 23.2.0 smmap: Not Installed timelib: 0.2.4 Tornado: 4.5.3 ZMQ: 4.3.4 System Versions: dist: ubuntu 20.04 focal locale: utf-8 machine: x86_64 release: 5.4.0-125-generic system: Linux version: Ubuntu 20.04 focal ```

Additional context

Other code is using sys.executable, too. These other occurrences must be fixed, too. If they just open a Python file, they can use /opt/saltstack/salt/run/run python for that.

Ch3LL commented 1 year ago

would you mind testing from these packages here: https://gitlab.com/saltstack/employees/development/ch3ll/salt-pkg/-/pipelines/639005216 this pipeline is building the onedir packages with my change in #62617

EDIT: I just realized you might not have permissions for that, so I will let you know when the PR is merged in and the nightly builds build off of the change and you can test those packages

Ch3LL commented 1 year ago

I have verified this is now working with the latest nightly build of packages:

(heist-3.8-1)  ch3ll@megan-precision5550  ~/Downloads/artifacts/3005+32.gb271eab491-1/salt  sudo -E ./run/run call --local cmd.run id runas=ch3ll
local:
    uid=1000(ch3ll) gid=1000(ch3ll) groups=1000(ch3ll),3(sys),90(network),98(power),991(lp),998(wheel)
(heist-3.8-1)  ch3ll@megan-precision5550  ~/Downloads/artifacts/3005+32.gb271eab491-1/salt 

I will close for now, but you can test them as well:

https://gitlab.com/saltstack/open/salt-pkg/-/pipelines/639419421

d--j commented 1 year ago

I have tested the latest nightly you linked to. It works ✅