saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here:
https://repo.saltproject.io/
Apache License 2.0
14.11k stars 5.47k forks source link

[BUG] 'modules.ethtool.set_ring' call a non-existant function 'get_ringparam' #62853

Open Stogas opened 1 year ago

Stogas commented 1 year ago

Description 'states.ethtool.ring' and 'modules.ethtool.set_ring' are currently unusable due to calling a non-existant function.

Setup ethtool.sls state:

ethtool_apply:
  ethtool.ring:
    - name: eth0
    - rx: 4096
    - tx: 4096

Salt-minion has ethtool installed:

# apt list --installed 2>/dev/null | grep ethtool
ethtool/stable,stable,now 1:5.9-1 amd64 [installed]
python3-ethtool/stable,stable,now 0.14-3+b3 amd64 [installed]
# pip3 list | grep ethtool
ethtool          0.14

Steps to Reproduce the behavior Run 'states.ethtool.ring' or 'modules.ethtool.set_ring' with any parameters. The result is:

----------
          ID: ethtool_apply
    Function: ethtool.ring
        Name: eth0
      Result: False
     Comment: module 'ethtool' has no attribute 'get_ringparam'
     Started: 21:01:03.596252
    Duration: 1.339 ms
     Changes:

Expected behavior State/module executes without errors and sets ring parameters

Versions Report

salt --versions-report ```yaml # salt --versions-report Salt Version: Salt: 3005.1 Dependency Versions: cffi: Not Installed cherrypy: unknown dateutil: 2.8.1 docker-py: Not Installed gitdb: 4.0.9 gitpython: 3.1.27 Jinja2: 2.11.3 libgit2: Not Installed M2Crypto: Not Installed Mako: Not Installed msgpack: 1.0.0 msgpack-pure: Not Installed mysql-python: Not Installed pycparser: Not Installed pycrypto: Not Installed pycryptodome: 3.9.7 pygit2: Not Installed Python: 3.9.2 (default, Feb 28 2021, 17:03:44) python-gnupg: Not Installed PyYAML: 5.3.1 PyZMQ: 20.0.0 smmap: 5.0.0 timelib: Not Installed Tornado: 4.5.3 ZMQ: 4.3.4 System Versions: dist: debian 11 bullseye locale: utf-8 machine: x86_64 release: 5.10.0-9-amd64 system: Linux version: Debian GNU/Linux 11 bullseye ```
salt-minion --versions-report ```yaml # salt-minion --versions-report Salt Version: Salt: 3005 Dependency Versions: cffi: 1.14.6 cherrypy: 18.6.1 dateutil: 2.8.1 docker-py: Not Installed gitdb: Not Installed gitpython: Not Installed Jinja2: 3.1.0 libgit2: Not Installed M2Crypto: Not Installed Mako: Not Installed msgpack: 1.0.2 msgpack-pure: Not Installed mysql-python: Not Installed pycparser: 2.21 pycrypto: Not Installed pycryptodome: 3.9.8 pygit2: Not Installed Python: 3.9.13 (main, Aug 23 2022, 18:31:09) python-gnupg: 0.4.8 PyYAML: 5.4.1 PyZMQ: 23.2.0 smmap: Not Installed timelib: 0.2.4 Tornado: 4.5.3 ZMQ: 4.3.4 System Versions: dist: debian 11 bullseye locale: utf-8 machine: x86_64 release: 5.10.0-9-amd64 system: Linux version: Debian GNU/Linux 11 bullseye ```
welcome[bot] commented 1 year ago

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!