search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here:
https://repo.saltproject.io/
Apache License 2.0
14.13k stars 5.47k forks source link

[BUG] "Recursive requisite found" in a state that worked before #65966

Open sylvainfaivre opened 8 months ago

sylvainfaivre commented 8 months ago

This problem appeared in the rabbitmq-formula's CI tests, with no code change in the formula, but changes to the Salt release used in the CI.

CI run on Dec 12, using saltstack master branch, commit fc65161d2e73138083c8aff2fbfc93d5a2af8d19 (merged on Dec 4) https://gitlab.com/saltstack-formulas/rabbitmq-formula/-/jobs/5734682005 From the log : You asked for latest and you have 3007.0+0na.fc65161 installed, sweet!

CI results : all OK.

CI run on Jan 11, using saltstack master branch, commit daef7613bc359822a4f04ffdd7a91a9edcac7c80 (merged on Jan 11) https://gitlab.com/saltstack-formulas/rabbitmq-formula/-/jobs/5912410639 From the log : You asked for latest and you have 3007.0+0na.daef761 installed, sweet!

Error in the CI run : 

       ----------
                 ID: rabbitmq-config-plugins-rabbit-rabbitmqadmin-install
           Function: cmd.run
               Name: curl -k -L http://127.0.0.1:15672/cli/rabbitmqadmin -o /usr/local/sbin/rabbitmqadmin
             Result: False
            Comment: Recursive requisite found
            Changes:   
       ----------

I looked a bit into the git log, and I think this might be caused by https://github.com/saltstack/salt/pull/65326/files which was merged on Dec 8, so it fits in the time frame, altough I'm not enough of a coder to really investigate it.

welcome[bot] commented 8 months ago

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

eedgar commented 6 months ago

The apache module is suffering from this issue also.

the reload, restart and apache service states all 3 claim a recursive issue is now happening. I revert from 3007.0 back to 3006.7 and the issue goes away

sylvainfaivre commented 4 months ago

https://github.com/saltstack/salt/pull/66135 might help, we'll see when it's merged