saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here:
https://repo.saltproject.io/
Apache License 2.0
14.15k stars 5.47k forks source link

[3006.x][BUG] Tools ts setup assumming aarch64 which is incorrect on Debian family platforms (inc Ubuntu) #66502

Closed dmurphy18 closed 5 months ago

dmurphy18 commented 5 months ago

Description The command 'tools ts setup' if it find arm64 in the slug assumes architecture 'aarch64', which is incorrect for Debian family of plaforms.

Setup Build a Debian family slug for arm64, and then try to use it, get an error *salt--onedir-linux-aarch64.tar.xz not found, whereas the correct file name is salt-3006.8+28.g662507a99e-onedir-linux-arm64.tar.xz**

Please be as specific as possible and give set-up details.

Steps to Reproduce the behavior

david@david-XPS-15-9570:~/devcode/dgm_salt_3006/salt$ tools ts setup --platform linux --slug ubuntu-22.04-arm64 --pr 65792 --pkg 2>&1 | tee ~/mytest.log
[10:14:47] Consider this in preliminary support. There are most likely things to iron out still.                                                                                                                                                                 
           Discovering the run_id(branch=None, nightly=None, pr=65792, repository='saltstack/salt')                                                                                                                                                              
           Got the GitHub token from the 'gh' CLI tool                                                                                                                                                                                                           
           Searching for workflow runs for HEAD SHA: 3e245920e17bcb1cc19ea5f0590ff99855a659c3                                                                                                                                                                    
[10:14:48] Discovered 1 workflow runs for HEAD SHA 3e245920e17bcb1cc19ea5f0590ff99855a659c3                                                                                                                                                                      
           Discovered run_id: 9021352516                                                                                                                                                                                                                         
           Searching for artifact salt-*-onedir-linux-aarch64.tar.xz from run_id 9021352516 in repository saltstack/salt ...                                                                                                                                     
           Got the GitHub token from the 'gh' CLI tool                                                                                                                                                                                                           
[10:14:49] Failed to find an artifact by the name of 'salt-*-onedir-linux-aarch64.tar.xz'                                                                                                                                                                        
david@david-XPS-15-9570:~/devcode/dgm_salt_3006/salt$

The error logs show name: salt-3006.8+28.g662507a99e-onedir-linux-arm64.tar.xz

Expected behavior The tools ts setup should be looking for salt-*-onedir-linux-arm64.tar.xz

s0undt3ch commented 5 months ago

Fix was merged into 3006.x

dmurphy18 commented 5 months ago

SO rough shod over review , if we no longer use aarch64 on artifacts names, I sure hope this is unaffected https://repo.saltproject.io/salt/py3/redhat/9/aarch64/latest/