welcome[bot]
commented
1 month ago Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:
- Community Wiki
- Salt’s Contributor Guide
- Join our Community Slack
- IRC on LiberaChat
- Salt Project YouTube channel
- Salt Project Twitch channel
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!
transistortim
What does this PR do?
The changes in this PR fix #66592 by making additional functions use async/await.
What issues does this PR fix or reference?
Fixes #66592
Previous Behavior
https://github.com/saltstack/salt/commit/11a06ce0dafd3d13c5b54961f9e0019539eac3f7 made some internal functions async. This broke functions calling these internal functions without await. This leads to the minion configuration option
startup_statesnot working any more.New Behavior
Starting the minion with startup_states now works as expected.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No. Is this required?
Note
Making more functions async might have introduced some more bugs I didn't catch yet. Specifically I've never used ProxyMinions and Syndic, maybe somebody with more experience could look into that.