[3006.x] The profile outputter does not crash with incorrectly formatted data

Akm0d commented 3 months ago

What does this PR do?

This PR fixes issues in the profile outputter, improving its handling of incorrectly formatted state returns and non-state returns. These changes ensure the outputter provides consistent and properly formatted output across a wider range of inputs.

What issues does this PR fix or reference?

Fixes #65104

Previous Behavior

The profile outputter would fail with a TypeError when processing:

Incorrectly formatted state returns.
Non-state returns, such as when running grains.items or querying for an SLS that doesn't exist.

New Behavior

The profile outputter now handles a broader range of input data types without crashing, providing a consistent, formatted table output. This includes:

Proper handling of grains data.
Graceful handling when no matching SLS is found or when the input data is non-standard.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

[x] Docs
[x] Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
[x] Tests written/updated

Commits signed with GPG?

Yes

max-arnold commented 2 months ago

This outputter was removed as part of the great module purge PR. Does this fix mean it is going to stay in core (due to merge forward), or it is better to convert it to extension?

dmurphy18 commented 2 months ago

@max-arnold This is just fixing the 3006.x and 3007.x branches (merge forward), great module purge stands and the fix will have to go into an extension, if the file was part of the great purge.

saltstack / salt