search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Install Salt from the Salt package repositories here:
https://docs.saltproject.io/salt/install-guide/en/latest/
Apache License 2.0
14.2k stars 5.48k forks source link

[3006.x] fix yaml output #66783

Closed tomdoherty closed 2 months ago

tomdoherty commented 3 months ago

In b9be2de, OrderedDict was replaced with HashableOrderedDict. Add logic to yamldumper to handle the new type.

What does this PR do?

What issues does this PR fix or reference?

Fixes #66594

Previous Behavior

% sudo salt-call state.show_sls salt.netbox-download --out=yaml
local: NULL
%

New Behavior

% sudo salt-call state.show_sls salt.netbox-download --out=yaml
local:
  salt.netbox-download_manage_file_netbox-download.sh:
    file:
    - name: /bootstrap/netbox-download.sh
    - source: salt://salt/netbox-download/files/netbox-download.sh
    - mode: '0755'
    - managed
    - order: 10002
...

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices, including the PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

dmurphy18 commented 2 months ago

@tomdoherty This might be better done on the 3006.x branch, given it is a 3006 bug, and the fix will see release sooner that any fix from the master branch. Fixes on 3006.x are merge-forwarded to 3007.x and master branches.

tomdoherty commented 2 months ago

@tomdoherty This might be better done on the 3006.x branch, given it is a 3006 bug, and the fix will see release sooner that any fix from the master branch. Fixes on 3006.x are merge-forwarded to 3007.x and master branches.

Thanks for the heads-up @dmurphy18! Done

welcome[bot] commented 2 months ago

Congratulations on your first PR being merged! :tada: