search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Install Salt from the Salt package repositories here:
https://docs.saltproject.io/salt/install-guide/en/latest/
Apache License 2.0
14.2k stars 5.48k forks source link

[3006.x] salt.utils.atomicfile: respect umask when creating files #66787

Closed terminalmage closed 3 months ago

terminalmage commented 3 months ago

What does this PR do?

Fixes a bug causing files created using salt.utils.atomicfile.atomic_open() to not respect the system umask.

What issues does this PR fix or reference?

Fixes #66786

Previous Behavior

Files were always created with a mode of 600

New Behavior

The umask is now respected.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

terminalmage commented 3 months ago

@dmurphy18 Will this require a rebase once the PR with the text fix is merged?

dmurphy18 commented 3 months ago

@terminalmage PR https://github.com/saltstack/salt/pull/66763 just got merged, updated the PR, and it should pass.