search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here:
https://repo.saltproject.io/
Apache License 2.0
14.17k stars 5.48k forks source link

[BUG] Startup_states are not applying on minion startup. #66831

Open newdamage1 opened 2 months ago

newdamage1 commented 2 months ago

Description Startup_states are not applying on minion startup.

Setup Master:

  interface: 10.10.1.150
  user: salt

Minion:

master: salt.mydomain.com
startup_states: 'sls'
sls_list:
  - my_startup_state
log_level: debug

my_startup_state.sls:

  /test.txt:
    file.managed:
     - makedirs: true
     - contents: |
        # This is a salt managed file.
         This is a test file!

Please be as specific as possible and give set-up details.

Ubuntu 2204 on both master and minion, running on ESXi8.

Steps to Reproduce the behavior Basic test setup, restarting service, or restarting the minion machine.

Expected behavior if I run a sudo salt-call state.apply my_startup_state from the minion. It will apply, but it will not after a server or service restart.

Screenshots N/A

Versions Report

salt --versions-report (Provided by running salt --versions-report. Please also mention any differences in master/minion versions.) Master Versions: ``` Salt Version: Salt: 3007.1 Python Version: Python: 3.10.14 (main, Apr 3 2024, 21:30:09) [GCC 11.2.0] Dependency Versions: cffi: 1.16.0 cherrypy: unknown dateutil: 2.8.2 docker-py: Not Installed gitdb: Not Installed gitpython: Not Installed Jinja2: 3.1.4 libgit2: Not Installed looseversion: 1.3.0 M2Crypto: Not Installed Mako: Not Installed msgpack: 1.0.7 msgpack-pure: Not Installed mysql-python: Not Installed packaging: 23.1 pycparser: 2.21 pycrypto: Not Installed pycryptodome: 3.19.1 pygit2: Not Installed python-gnupg: 0.5.2 PyYAML: 6.0.1 PyZMQ: 25.1.2 relenv: 0.16.0 smmap: Not Installed timelib: 0.3.0 Tornado: 6.3.3 ZMQ: 4.3.4 Salt Package Information: Package Type: onedir System Versions: dist: ubuntu 22.04.4 jammy locale: utf-8 machine: x86_64 release: 5.15.0-118-generic system: Linux version: Ubuntu 22.04.4 jammy ``` minion version: ``` Salt Version: Salt: 3007.1 Python Version: Python: 3.10.14 (main, Apr 3 2024, 21:30:09) [GCC 11.2.0] Dependency Versions: cffi: 1.16.0 cherrypy: 18.8.0 dateutil: 2.8.2 docker-py: Not Installed gitdb: Not Installed gitpython: Not Installed Jinja2: 3.1.4 libgit2: Not Installed looseversion: 1.3.0 M2Crypto: Not Installed Mako: Not Installed msgpack: 1.0.7 msgpack-pure: Not Installed mysql-python: Not Installed packaging: 23.1 pycparser: 2.21 pycrypto: Not Installed pycryptodome: 3.19.1 pygit2: Not Installed python-gnupg: 0.5.2 PyYAML: 6.0.1 PyZMQ: 25.1.2 relenv: 0.16.0 smmap: Not Installed timelib: 0.3.0 Tornado: 6.3.3 ZMQ: 4.3.4 Salt Package Information: Package Type: onedir System Versions: dist: ubuntu 22.04.4 jammy locale: utf-8 machine: x86_64 release: 6.8.0-40-generic system: Linux version: Ubuntu 22.04.4 jammy ``` ```yaml PASTE HERE ```

Additional context Add any other context about the problem here.

welcome[bot] commented 2 months ago

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

whytewolf commented 2 months ago

Hey, I did trouble shoot this a little bit salt team.

looks like this line is not actually running or getting added to the event loop tasks. https://github.com/saltstack/salt/blob/master/salt/minion.py#L2429

most likely should be put through asyncio.create_task

dmurphy18 commented 2 months ago

@dwoz Wondering if your payload fix resolves this issue

momolemo commented 2 months ago

duplicate https://github.com/saltstack/salt/issues/66592 ?