[BUG] Create Docker container with a custom MAC address

hatamiarash7 commented 6 days ago

Description We can't create a Docker container with a custom MAC address due to the docker package problem.

Setup

[ x ] on-prem machine
[ x ] used bootstrap to install

Steps to Reproduce the behavior

Try to create a docker container with the mac_address option.
The created container does not have any Network.host.MacAddress value.

Expected behavior

Create Docker container

Screenshots

Versions Report

salt --versions-report

```yaml Salt Version: Salt: 3006.5 Python Version: Python: 3.9.2 (default, Feb 28 2021, 17:03:44) Dependency Versions: cffi: 1.16.0 cherrypy: Not Installed dateutil: 2.8.1 docker-py: 7.1.0 gitdb: Not Installed gitpython: Not Installed Jinja2: 3.1.3 libgit2: Not Installed looseversion: 1.3.0 M2Crypto: Not Installed Mako: Not Installed msgpack: 1.0.7 msgpack-pure: Not Installed mysql-python: Not Installed packaging: 23.2 pycparser: 2.21 pycrypto: Not Installed pycryptodome: 3.20.0 pygit2: Not Installed python-gnupg: Not Installed PyYAML: 6.0.1 PyZMQ: 25.1.2 relenv: Not Installed smmap: Not Installed timelib: Not Installed Tornado: 4.5.3 ZMQ: 4.3.4 System Versions: dist: debian 11.11 bullseye locale: utf-8 machine: x86_64 release: 5.10.0-30-amd64 system: Linux version: Debian GNU/Linux 11.11 bullseye ```

Additional context

I think there is a problem with the create_host_config function in the docker-py package as I mentioned here. There isn't any mac_address option for this function, therefore we'll see a warning:

[WARNING ] The following arguments were ignored because they are not recognized by docker-py: ['mac_address']

welcome[bot] commented 6 days ago

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey. Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

Kranium2002 commented 1 day ago

Hi, I would like to work on this issue. Could you maybe assign it to me and guide me to solve this?

saltstack / salt

[BUG] Create Docker container with a custom MAC address #66882