Open OrangeDog opened 1 week ago
@OrangeDog Can you give example for your statement
It seems like the fix for https://github.com/saltstack/salt/issues/66590 was never tested, as it still doesn't work.
...?
If it had been tested, then it would have found this issue. Unless there's some weird obscure case I'm hitting.
Pull in those changes from Suse, see https://github.com/openSUSE/salt/pull/673/files, revisiting those changes now for second view.
@dmurphy18 those are separate issues. That pull request fixes only the oid
getting deprecated. There's a separate issue with newer pygit2
where salt is failing to talk to git because of the aforementioned
AttributeError: '_pygit2.Blob' object has no attribute 'hex'
@viq I am digging in and testing and fixing it all at the same time.
newer
pygit2
Nope. The error starts in the same version: 1.15.0
Description gitfs and git_pillar do not work with pygit2 >= 1.15.0, rasing exceptions as below:
Setup
Steps to Reproduce the behavior
While filserver contents can be listed (e.g. with
salt-run fileserver.file_list
), a highstate cannot be run, and pillar appears empty.Expected behavior Git features continue to work as with previous pygit2 versions.
Versions Report
salt --versions-report
```yaml Salt Version: Salt: 3006.9 Python Version: Python: 3.10.14 (main, Jun 26 2024, 11:44:37) [GCC 11.2.0] Dependency Versions: cffi: 1.17.1 cherrypy: unknown cryptography: 42.0.5 dateutil: 2.8.1 docker-py: Not Installed gitdb: Not Installed gitpython: Not Installed Jinja2: 3.1.4 libgit2: 1.8.1 looseversion: 1.0.2 M2Crypto: 0.38.0 Mako: Not Installed msgpack: 1.0.2 msgpack-pure: Not Installed mysql-python: Not Installed packaging: 22.0 pycparser: 2.21 pycrypto: Not Installed pycryptodome: 3.19.1 pygit2: 1.16.0 python-gnupg: 0.4.8 PyYAML: 6.0.1 PyZMQ: 23.2.0 relenv: 0.17.0 smmap: Not Installed timelib: 0.2.4 Tornado: 4.5.3 ZMQ: 4.3.4 System Versions: dist: ubuntu 24.04.1 noble locale: utf-8 machine: x86_64 release: 6.8.0-47-generic system: Linux version: Ubuntu 24.04.1 noble ```Additional context It seems like the fix for #66590 was never tested, as it still doesn't work.