search

saltyorg / Saltbox

Ansible-based solution for rapidly deploying a Docker containerized cloud media server.
https://docs.saltbox.dev
GNU General Public License v3.0
571 stars 65 forks source link

Add PowerDNS as DNS provider #144

Closed patricksindelka closed 1 year ago

patricksindelka commented 1 year ago

Small change to add PowerDNS

saltydk commented 1 year ago

I've made a small edit to make the setting have a more descriptive name.

saltydk commented 1 year ago

I have already fixed the mistake with the variable, noticed it after committing.

patricksindelka commented 1 year ago

I agree that the name PowerDNS is better but pdns is the provider code in Traefik. If you change the name to PowerDNS, it also changes the value of the {{ traefik_challenge_provider }} field to that, which is used in the docker commands.

saltydk commented 1 year ago

I did not edit the ENV so I don't follow.

On Wed, 24 May 2023, 01:50 Patrick Sindelka, @.***> wrote:

I agree that the name PowerDNS is better but pdns is the provider code in Traefik. If you change the name to PowerDNS, it also changes the value of the {{ traefik_challenge_provider }} field to that, which is used in the docker commands.

— Reply to this email directly, view it on GitHub https://github.com/saltyorg/Saltbox/pull/144#issuecomment-1560266221, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSIMLUI7LVVBJFEVTKR7FLXHVEMVANCNFSM6AAAAAAYMIFBZY . You are receiving this because you modified the open/close state.Message ID: @.***>

saltydk commented 1 year ago

I get your point now. I will try seeing if I can rename it under the hood as pdns is not very descriptive.

On Wed, 24 May 2023, 05:17 René Madsen, @.***> wrote:

I did not edit the ENV so I don't follow.

On Wed, 24 May 2023, 01:50 Patrick Sindelka, @.***> wrote:

I agree that the name PowerDNS is better but pdns is the provider code in Traefik. If you change the name to PowerDNS, it also changes the value of the {{ traefik_challenge_provider }} field to that, which is used in the docker commands.

— Reply to this email directly, view it on GitHub https://github.com/saltyorg/Saltbox/pull/144#issuecomment-1560266221, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSIMLUI7LVVBJFEVTKR7FLXHVEMVANCNFSM6AAAAAAYMIFBZY . You are receiving this because you modified the open/close state.Message ID: @.***>

saltydk commented 1 year ago

I have added a powerdns to pdns string replacement to the underlying variable so it should work fine now.