search

saltyorg / Saltbox

Ansible-based solution for rapidly deploying a Docker containerized cloud media server.
https://docs.saltbox.dev
GNU General Public License v3.0
571 stars 65 forks source link

feat(media-server): make autoscan deployment overridable #175

Closed keldian closed 8 months ago

keldian commented 8 months ago

I figured it would be cleaner than my current solution of adding media-server to skipped tags, for skipping autoscan.

saltydk commented 8 months ago

I'm more inclined to make it take another list so people can add/remove companion apps to it instead.

saltydk commented 8 months ago

something along the lines of 

media_servers_companion_apps_enabled: ["autoscan"]
saltydk commented 8 months ago

That would be more along the lines of what we want to do going forward instead of having the main tags.

keldian commented 8 months ago

Sounds good. That's actually what I was entertaining at first, but then I thought there might have to be error handling involved so I opted to keep it simple.

saltydk commented 8 months ago

Do you mind if I close this and just table it until I get around to doing the main tag workaround?

keldian commented 8 months ago

No problem.

saltydk commented 8 months ago

I've added a feature request issue to keep track of it so I don't forget to get around to it again :p