search

saltyorg / Saltbox

Ansible-based solution for rapidly deploying a Docker containerized cloud media server.
https://docs.saltbox.dev
GNU General Public License v3.0
571 stars 65 forks source link

Cadvisor doesn't deploy with any traefik reverse proxy labels #187

Closed edrock200 closed 4 months ago

edrock200 commented 4 months ago

Describe the bug Cadvisor has a web interface, on 8080, but saltbox doesn't deploy with the traefik labels needed to make it accessible via the reverse proxy.

To Reproduce Steps to reproduce the behavior:

  1. sb install cadvisor
  2. docker inspect cadvisor # look for traefik labels

Expected behavior Traefik labels get deployed with cadvisor

System Information

saltydk commented 4 months ago

Do you have a use case that requires external access? It was built this way since the access externally was not required.

edrock200 commented 4 months ago

Do you have a use case that requires external access? It was built this way since the access externally was not required.

To see the container stats via the built in gui. It appears the web server runs either way, so it won't be using more reeources exposing it behind authelia/traefik. For those just running a single host setup, they most likely won't be rolling it up to a data ingest for grafana style dashboards. Netdata is great, but a bit like drinking from a firehose, especially when trying to see stats for individual containers.

owine commented 4 months ago

Just for the record, given the way the templating works, you can set the traefik variables via inventory to make the webui accessible via traefik. The DNS would require manual setup

saltydk commented 4 months ago

I don't mind exposing the dashboard behind Authelia but if you need the API endpoints you'd have to do that research and make a PR.