saltyorg / Saltbox

Ansible-based solution for rapidly deploying a Docker containerized cloud media server.
https://docs.saltbox.dev
GNU General Public License v3.0
573 stars 65 forks source link

Change nomenclature in backup config #34

Closed chazlarson closed 2 years ago

chazlarson commented 2 years ago
  cron:
    cron_time: weekly
    cron_state: absent/present

That "absent/present" thing is really non-intuitive. I'd suggest changing it to something like:

  cron:
    cron_time: weekly
    schedule_with_cron: yes/no
saltydk commented 2 years ago

Do we want to go away from special time as well and just expose minute, hour, day, weekday, month?

My initial suggestion to the format would be

cron:
  cron_time: weekly
  enabled: yes/no
chazlarson commented 2 years ago

I think the simple "daily, weekly, etc" are fine. If someone wants to slice it finer than that they can edit crontab themselves.

I'm less fond of the past-tense "enabled", since I think the problem is that people think that value reflects the current state of the cron job, not how you want it to end up after you run the tag.

saltydk commented 2 years ago
cron:
  cron_time: weekly
  enable: yes/no

So we just go with this?

chazlarson commented 2 years ago

That seems fine to me.