search

saltyorg / Saltbox

Ansible-based solution for rapidly deploying a Docker containerized cloud media server.
https://docs.saltbox.dev
GNU General Public License v3.0
573 stars 65 forks source link

Ansible: Rework port variables. #46

Closed saltydk closed 2 years ago

saltydk commented 2 years ago

Currently doesn't make a whole lot of sense

sonarr_docker_ports_defaults:
  - "{{ sonarr_web_port }}"
sonarr_docker_ports_custom: []
sonarr_docker_ports: "{{ sonarr_docker_ports_defaults
                         + sonarr_docker_ports_custom
                      if (not reverse_proxy_is_enabled)
                      else [] + sonarr_docker_ports_custom }}"

Where defaults is only active if running without reverse proxy and you need to add another variable to add "default" port bindings. Should make a webui specific port label so that defaults will contain the ports that need to be used in addition to the webui port.