search

saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
68 stars 94 forks source link

Miniflux #204

Closed powerdude closed 1 year ago

powerdude commented 1 year ago

Description

A minimalist rss reader - http://miniflux.app

https://hub.docker.com/r/miniflux/miniflux

How Has This Been Tested?

Tested with an existing config data from a previous ansible tool and from scratch in new SB environment

owine commented 1 year ago

Linting failed

[yaml[new-line-at-end-of-file]: roles/miniflux/defaults/main.yml#L161](https://github.com/saltyorg/Sandbox/pull/204/files#annotation_7217608594)
No new line character at the end of file
owine commented 1 year ago

Looks like the db user/password are circular references. I would remove the the postgres user and pass from the vars section when calling the postgres role and let the default user/pass be used from that role.

powerdude commented 1 year ago

the problem I was trying to solve with those is that I had an existing installation of miniflux and it had a different username/password for the db, so I needed a way to override them for this postgres db, but not for others. Would using lookup in the defaults or using it in the task help? I also had to override volumes in my inventory due to the /etc/passwd.

owine commented 1 year ago

The way you've structured the role, a separate postgres container will be created specifically for use here.

powerdude commented 1 year ago

Yes, but the postgres vars are global, so changing it in the inventory affects all dbs, so a separate var is needed for overrides and I was hoping to default it so it would just work. Am I missing something here?

Thanks

From: owine @.> Sent: Friday, December 16, 2022 6:52:03 PM To: saltyorg/Sandbox @.> Cc: powerdude @.>; Author @.> Subject: Re: [saltyorg/Sandbox] Miniflux (PR #204)

The way you've structured the role, a separate postgres container will be created specifically for use here.

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsaltyorg%2FSandbox%2Fpull%2F204%23issuecomment-1355843660&data=05%7C01%7C%7C85042b6de5254eea1d4308dadfc088bf%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638068315267239003%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=krenP64KvGe1CmtUepyGBLkosQfEWAYMI7QkFwW5GAM%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAF6UUQR7FGMJATRX42IWIDWNT6CHANCNFSM6AAAAAATBSFQUI&data=05%7C01%7C%7C85042b6de5254eea1d4308dadfc088bf%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638068315267395233%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HcX9h4TuMi2WROHEzff%2FTKZn0%2FgxBIl2%2FTLk0VgWeU8%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

owine commented 1 year ago

I am not understanding the need to override these outside of your individual environment for testing.

But with that said, you could default miniflux_postgres_username and password to blank and have the var passed to the postgres role only if miniflux_postgres_username/password are populated and otherwise default to omit.