search

saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
68 stars 94 forks source link

rename `coder` to `code_server` #207

Closed GiorgioBrux closed 1 year ago

GiorgioBrux commented 1 year ago

Description

Renamed coder to code_server since coder is now a different software. The old coder folder would not be automatically renamed, so anyone using the old role would have to manually rename it and then run the new tag.

How Has This Been Tested?

Even if it's a simple rename I tested it and it works as expected.

saltydk commented 1 year ago

Since this is a breaking change it should migrate the old opt folder or have some kind of method to deal with that.

saltydk commented 1 year ago

Maybe @owine can help you with how to make the migration specific to this role and not moving the opt folder if you use the 'real' coder.

GiorgioBrux commented 1 year ago

Yep, I wasn't totally sure how to handle the migration assuming someone could be already running the real coder and using the coder folder. I'll try looking into it later.

GiorgioBrux commented 1 year ago

Let me know if I should change/add anything else.

owine commented 1 year ago 
[yaml[indentation]: roles/code_server/tasks/subtasks/legacy.yml#L36](https://github.com/saltyorg/Sandbox/pull/207/files#annotation_7276666352)
Wrong indentation: expected 8 but found 10
GiorgioBrux commented 1 year ago 
[yaml[indentation]: roles/code_server/tasks/subtasks/legacy.yml#L36](https://github.com/saltyorg/Sandbox/pull/207/files#annotation_7276666352)
Wrong indentation: expected 8 but found 10

Oops, fixed.

GiorgioBrux commented 1 year ago

Making it a draft again so I can fix the CI not passing.

GiorgioBrux commented 1 year ago

Alright, should work now. Thanks very much for the suggestions.

owine commented 1 year ago 
[yaml[trailing-spaces]: roles/code_server/tasks/subtasks/legacy.yml#L29](https://github.com/saltyorg/Sandbox/pull/207/files#annotation_7279686803)
Trailing spaces

[yaml[empty-lines]: roles/code_server/tasks/subtasks/legacy.yml#L54](https://github.com/saltyorg/Sandbox/pull/207/files#annotation_7279686814)
Too many blank lines (1 > 0)

[yaml[new-line-at-end-of-file]: roles/coder/tasks/main.yml#L13](https://github.com/saltyorg/Sandbox/pull/207/files#annotation_7279686820)
No new line character at the end of file
GiorgioBrux commented 1 year ago

My god I fix something and break something else, apologies, 1 minute.