saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
66 stars 92 forks source link

PlexMetaManager: Multi-Instance Support #238

Closed PuppyLover101 closed 7 months ago

PuppyLover101 commented 1 year ago

Describe the problem Allow for PlexMetaManager to have multiple app instances

Describe any solutions you think might work No traefik subdomains needed, just additional containers need to be spawned based on naming convention supplied on inventory.

Why is this neccessary? Multiple docker containers are better for multiple libraries to speed up the process of each category. This is especially noticeable on larger libraries.

saltydk commented 1 year ago

PMM isn't in Saltbox.

chazlarson commented 1 year ago

Running multiple PMM instances simultaneously against the same Plex instance is probably not going to improve performance significantly [since Plex is still receiving the same number of API requests, just from different sources] and may very well cause problems, so this will/would need to be festooned with caveats.

PuppyLover101 commented 1 year ago

This also helps with config management, which is the biggest reason for my request. I have specific config files for each Library source, and I don't want one docker to run it all.

saltydk commented 1 year ago

Nothing prevents you from deploying multiple with the current role but having instances would need to have more upside than potential downside and outside of running multiple different Plex servers it seems without a decent use case to me.

chazlarson commented 1 year ago

The simplest way to manage this is going to be via docker run commands kicking off manual runs with different configs, or docker run commands creating containers, or setting up the containers using docker-compose or the like. You stated use case will add a bunch of complication to the sb settings [which config goes with which container? What's the schedule for this container vs another?], when it's just a simple to make those same settings directly.

I see a solution in search of a problem here.

maximuskowalski commented 1 year ago

Nothing prevents you from deploying multiple with the current role but having instances would need to have more upside than potential downside and outside of running multiple different Plex servers it seems without a decent use case to me.

There are config options on a per library basis and even per plex instance or server, have run it against three very very very large libraries from the same PMM instance without issue.

saltydk commented 1 year ago

Nothing prevents you from deploying multiple with the current role but having instances would need to have more upside than potential downside and outside of running multiple different Plex servers it seems without a decent use case to me.

There are config options on a per library basis and even per plex instance or server, have run it against three very very very large libraries from the same PMM instance without issue.

Still doesn't make it a good idea.

maximuskowalski commented 1 year ago

I was meaning that even for different plex instances there is no need for multiple PMM instances. Config can be per library and server.

I cant see a use case for multi instance PMM.

saltydk commented 1 year ago

I was meaning that even for different plex instances there is no need for multiple PMM instances. Config can be per library and server.

I cant see a use case for multi instance PMM.

Fair enough, that was not how I read that :p