search

saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
66 stars 92 forks source link

Add role: Membarr #257

Closed RaneyDazed closed 11 months ago

RaneyDazed commented 1 year ago

Description

Will create docs for it if it gets that far. I was hoping someone could give this a once over, as I'm struggling to figure out if I'm doing something wrong or if the bot/role itself is the problem.

How Has This Been Tested?

I've tested it on my home server and my feederbox. It connects fine to discord and the bot works and responds well. Everything looks good there. Only issue is it doesn't seem to want to connect to plex and I need someone or a few people to test it for me maybe? Thanks!

RaneyDazed commented 1 year ago

should this be converted to a draft?

RaneyDazed commented 1 year ago

so after figuring out how it works, I'll have to create docs for it regardless because its not documented well in the first place. anyone who decides to take a look at it, please lmk what you think, the container creates the config.ini file on its own, but I can create a jinja template that will fill in the plex details. the thing is, if this is installed on a separate saltbox server IE feeder, there won't be a plex url. so IG best way to do it is to just document how to set it up yeah? or we could add it to settings.yml, but iirc you all wanted to step away from that..?

either way, it works as intended right now, just gotta fill in relevant info in a file.

ifelsee101 commented 1 year ago

@RaneyDazed Thanks for creating this role. I was able to test this, and it works as expected after adding 'plex_base_url = http://plex:32400' to the config.ini file. Setting up through discord channel added a weird long url to plex_base_url, I changed it to above and it worked fine.

keldian commented 1 year ago

Make a template for the config file. For the Plex URL, use plex_web_url—don't hardcode it.

If the token can't be passed via the config file, use an env file instead of settings.yml (check Watchtower for inspiration).

maximuskowalski commented 1 year ago

Is a template being made for this @RaneyDazed?

RaneyDazed commented 1 year ago

will be messing with this in a bit! Sorry its taken so long. I forgot about it after I read the notification.

RaneyDazed commented 1 year ago

Still working on it, about done with the template and I'll test it out on a box or two. @keldian @maximuskowalski

RaneyDazed commented 1 year ago

Still working on it, about done with the template and I'll test it out on a box or two. @keldian @maximuskowalski

Well the template and subtask

RaneyDazed commented 1 year ago

Should be all set..?

maximuskowalski commented 11 months ago

Docs PR all that we need then and ready to go?

RaneyDazed commented 11 months ago

Yup thats correct! although i was unaware it was waiting for a Docs pr before it would be approved. I'd have done that ages ago. I just didn't want to bother if it wasn't going to be approved. But I can write up some docs!

maximuskowalski commented 11 months ago

Everything needs docs before it will be merged now.

maximuskowalski commented 11 months ago

https://github.com/saltyorg/docs/pull/205