search

saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
64 stars 91 forks source link

Changed volumes #289

Closed nickheyer closed 9 months ago

nickheyer commented 9 months ago

Description

Updated volumes for new version of DiscoFlix. Regular maintenance, etc.

How Has This Been Tested?

On local server.

saltydk commented 9 months ago

?

nickheyer commented 9 months ago

?

I deleted the PR, it needs more work. Also, do you know why DiscoFlix was removed from sandbox.yml?

Was this intentional? If so, the role dir for DiscoFlix was left behind.

nickheyer commented 9 months ago

To give you some context, I rewrote the entire application. I went from a flask application running the discord bot in a subprocess to a Django application running it within a "channels worker" - which uses an in memory database to serve as an async queue (ASGI).

It's working if I pull the container and run docker run -d -p 5454:5454 nickheyer/discoflix, but not currently under saltbox infrastructure. Logs don't show any errors.

owine commented 9 months ago

?

I deleted the PR, it needs more work. Also, do you know why DiscoFlix was removed from sandbox.yml?

Was this intentional? If so, the role dir for DiscoFlix was left behind.

No a PR inadvertently removed it. Fixed in https://github.com/saltyorg/Sandbox/commit/32a175f11a6194375947ec13dbd567ddd97962b5

saltydk commented 9 months ago

If I had to guess the Sandbox maintainers messed up when merging a PR, they have happy trigger fingers.

On Mon, 25 Sep 2023, 18:18 Nicholas W. Heyer, @.***> wrote:

?

I deleted the PR, it needs more work. Also, do you know why DiscoFlix was removed from sandbox.yml?

Was this intentional? If so, the role dir for DiscoFlix was left behind.

— Reply to this email directly, view it on GitHub https://github.com/saltyorg/Sandbox/pull/289#issuecomment-1734071682, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSIMLWSHSLLZ2OPVJAYVODX4GVDPANCNFSM6AAAAAA5FTGMSY . You are receiving this because you commented.Message ID: @.***>

nickheyer commented 9 months ago

If I had to guess the Sandbox maintainers messed up when merging a PR, they have happy trigger fingers. … On Mon, 25 Sep 2023, 18:18 Nicholas W. Heyer, @.> wrote: ? I deleted the PR, it needs more work. Also, do you know why DiscoFlix was removed from sandbox.yml? Was this intentional? If so, the role dir for DiscoFlix was left behind. — Reply to this email directly, view it on GitHub <#289 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSIMLWSHSLLZ2OPVJAYVODX4GVDPANCNFSM6AAAAAA5FTGMSY . You are receiving this because you commented.Message ID: @.>

I also have happy trigger fingers, I shouldve mentioned that the role will currently not work since the docker image is the refactored version, but the saltbox files are based on the previous implementation. I should have an updated version tonight.

Silly issue on my end I know, but with the new refactor, I basically only need to mount a single file to /opt/discoflix and not the entire directory (it's in the projects root dir). The file also doesnt exist when the container is first run - which is why I think my attempt failed.