saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
63 stars 91 forks source link

Match Tubearchivist compose #322

Closed Nypheena closed 5 months ago

Nypheena commented 5 months ago

This is to match the tubearchivist compose for elasticsearch https://github.com/tubearchivist/tubearchivist/blob/master/docker-compose.yml Hope I did it right

saltydk commented 5 months ago

Is this just to bump security or to fix something? There is no cause/problem explained here?

Nypheena commented 5 months ago

Is this just to bump security or to fix something? There is no cause/problem explained here?

its mostly to get it all up to date with the actual compose of tubearchivist as owine already had to make a few pushes to fix it all up, I suppose as its not running on external network the security aspect is irrelevant

saltydk commented 5 months ago

I wouldn't say irrelevant but the attack vector is somewhat reduced to applications running on the host or on the same network.

Nypheena commented 5 months ago

I wouldn't say irrelevant but the attack vector is somewhat reduced to applications running on the host or on the same network.

I personally like to add as much security as I can just because but nothing I'm aware of that it fixes, its just a small security bump

saltydk commented 5 months ago

Doesn't appear to break anything so don't see any reason not to merge this @owine