Update ES to official repo and tag

[Nypheena]

This updates the Elasticsearch repo to the official one now on hub as well as the tag tubearchivist recommends although latest is 8.12.0 but I only know 8.11.0 works

[saltydk]

This change should be added to the TubeArchivist role instead. Override the variable in the include_role task as you risk breaking other roles that don't override the version.

[Nypheena]

I guess, but its 2 years old, its not even using official repo and tag is very outdated one way or another it needs an update

[saltydk]

I just looked at the other role and it overrides the image variable anyway so it already uses latest and this change wouldn't affect tubearchivist either way.

[Nypheena]

yeah I didn't make it solely for tubearchivist it was to update something abandoned and old but I looked into it because of tubearchivist, I don't know enough about github to check what else could be using it but I would imagine they could still benefit from official repo

[saltydk]

I understand, I believe the intent is to never really use any of the role defaults as far as versions going forward hence the decision to just leave it be. If someone wants to use it manually they have the inventory to change it to whatever supported version they need.

[Nypheena]

Fair enough, what about changing the repo at least to official but keeping same version?

[saltydk]

This role is already the official image, no?

[saltydk]

https://www.elastic.co/guide/en/elasticsearch/reference/current/docker.html based on their own docs at least.

[Nypheena]

Seems to be on their own registry yeah, I was more referring to docker hub for redundancy but doesn't look like its needed as long they don't change the link

[saltydk]

Not seeing the redundancy aspect of using Docker Hub but I suspect they are not going anywhere anytime soon as their registry has existed since 2016.

[Nypheena]

Maybe just my weird thinking that it would basically mean even if url changed docker hub is always there as the main docker source kind of thing and they are even marked as an official image on there

[saltydk]

I get it but on our side it makes sense to use other registries whenever official ones exist as it helps reduce the chance that a user hits Docker Hub API limits, small edge case but that means there is a potential upside there at least.

[Nypheena]

Ah makes sense, wasn't really aware of api limits

[saltydk]

It is why the dockerhub auth bits in accounts.yml exist :)