saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
63 stars 91 forks source link

Notifiarr: Update image link to ghcr #330

Closed Nypheena closed 2 months ago

Nypheena commented 4 months ago

Due to rate limits and Docker hub taking 80+ minutes to build versus Github taking 15 minutes to build they will be swapping over, stable is yet to be until the next push so I'm only making a draft until then but also gives you a chance to reject early if you don't wanna do this swap at all

1fb2eda7-5e0d-4bcd-bbb9-ae72617394af 3f625490-3607-4c0e-980f-9263fd2beda9

saltydk commented 4 months ago

He could just push to dockerhub from GHA, rofl.

Nypheena commented 4 months ago

That was discussed but there was something about a dockerfile not being an option if doing so? I admit that went over my head but I do know many are using github for their images from what I've seen or at least their own repo somewhere such as elasticsearch but I know the api limits on docker hub is a concern I've seen mentioned many places

saltydk commented 4 months ago

Sounds like dumb excuses to me, notifiarr is not even remotely as widely used as something like elasticsearch.

Nypheena commented 4 months ago

I’m far from an expert, I can delete it if you are against it

saltydk commented 4 months ago

Well, if he isn't going to build for Dockerhub then it will be needed. I'm just saying that none of the explanations here make any sense.

Nypheena commented 4 months ago

I do not believe he is gonna stop due to being sponsored on docker hub so I suppose it won’t really be needed except for those who help test on unstable branch but they would likely know how to change in inventory then

if you have access to the tester channel on notifiarr you could always look at it yourself I don’t know enough about docker in this

saltydk commented 4 months ago

You can still leave this open, @owine might disagree with me and he runs this.

owine commented 4 months ago

I’m in favor

saltydk commented 2 months ago

@owine you handling this or?

saltydk commented 2 months ago

Although unstable should probably not be the default tag

owine commented 2 months ago

It's just unstable to pass CI for the moment, waiting for upstream to publish :latest to GHCR so the PR can be updated and merged.