search

saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
70 stars 97 forks source link

fix(firefox): make the wait task less disruptive #337

Closed keldian closed 7 months ago

saltydk commented 7 months ago

Less disruptive by making it pointless or?

keldian commented 7 months ago

Well the idea of that task was never to stop the execution of the role, it's just to allow enough time for directories to populate, so that the next task doesn't delete the wrong ones. I don't view it as pointless as 30s should be enough time for that to happen anyway. *shrug*

saltydk commented 7 months ago

Then change the task to look for the files instead of make it silently fail if there is something wrong with the deployment

saltydk commented 7 months ago

You can shrug all you want, it doesn't change how it looks.

saltydk commented 7 months ago

This just seems to be in response to what sevos wrote on the discord and I'm betting he just deployed ufw and broke it himself.

keldian commented 7 months ago

I know. :p Just shrugging because I don't mind canceling this, especially if you figure it was fine as it was.

Then change the task to look for the files instead of make it silently fail if there is something wrong with the deployment

I'll look into that at some point.

saltydk commented 7 months ago

Deluge role has an example from what I remember.