saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
72 stars 99 forks source link

Issue: Some Deemix settings lost on update #34

Closed YozoraXCII closed 1 year ago

YozoraXCII commented 2 years ago

When updating Deemix using the sb install sandbox-deemix code, a few settings are reset:

Is it possible for these settings to be retained?

Also, unsure about the general guidance but the Deemix URL is exposed by default as there is no 2FA for login, should Authelia be included in the default template?

saltydk commented 2 years ago

download folder is reset on container start, which I personally consider bad practise, so we cannot do anything about that outside of finding a new image.

https://gitlab.com/Bockiii/deemix-docker/-/blob/master/root/etc/cont-init.d/10-fix_folders#L12

As far as the login credentials we're mounting the config folder as specified by the documentation of the image and not sure what we can do about it outside of that. I suggest you take that up with the image maintainer https://gitlab.com/Bockiii/deemix-docker/-/issues

Max can probably throw Authelia on this role when he has a moment.

kungfoome commented 2 years ago

I'm not getting the login issue. It seems to retain my login creds after updating. I'll keep an eye out for that though. The downloads thing is super annoying. A workaround is to mount what you want to /downloads instead.

deemix_docker_volumes_custom:
  - /mnt/unionfs/Media/Music:/downloads

Authelia was added and merged already https://github.com/saltyorg/Sandbox/pull/95

saltydk commented 2 years ago

You should probably remove the regular download volume mounts then.

saltydk commented 2 years ago
deemix_docker_volumes_global: false

That should do it.

maximuskowalski commented 1 year ago

It's been a year, is this still an issue?