saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
73 stars 101 forks source link

Teslamate secrets fix #396

Closed maindust closed 2 weeks ago

maindust commented 2 weeks ago

Description

For existing roles;

The issue we were having was that two .ini's were generated and two fact sheets were made. I merged both facts into a singular sheet and created a single .ini to store it. I then added a tag in tasks that allows the user to run sb install sandbox-teslamate-grafana to grab the DB password the user needs when setting up the data source in grafana.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration. You can use the checkboxes below or delete them as you wish.

saltydk commented 2 weeks ago

This seems partially handled as you would have to migrate the old postgres password when doing this to avoid causing issues for users who already deployed this, no?

maindust commented 2 weeks ago

That's fair. What's the preferred method for me to give those who have already deployed the conversion steps? I can make a section in tasks that changes the existing users db pass to the new. Use a trigger of sb install sandbox-teslamate-db-fix or I can put instruction on the docs.

saltydk commented 2 weeks ago

I can commit a fix tomorrow, sick today so won't rack my brain about the specifics today.

maindust commented 2 weeks ago

Thanks for the help dude. Hope you get to feeling better soon.

saltydk commented 2 weeks ago

I've made some tweaks, one of which will require a tweak to the docs I suspect, I believe that users would assume more grafana automation if we used that naming.