saltyorg / docs

GNU General Public License v3.0
48 stars 76 forks source link

Firefox role (Sandbox) + add mkdocs-material privacy plugin #223

Closed keldian closed 9 months ago

keldian commented 10 months ago

Fully previewed and tested using the Insiders edition.

Also, extra.css got linted as I added some things.

saltydk commented 10 months ago

The privacy plugin addition adds far more than what you wanted to add it for. Even if you left out the other settings most of them default to true.

keldian commented 10 months ago

Oof, that went over my head.

Looks like it's just assets that would have to be overridden right? To my understanding concurrency and all other asset related options depend on that one being enabled.

saltydk commented 10 months ago

Yeah, by default it downloads all external assets and bundles them in the build. All of which probably slows the build time locally, this can be fixed with an ENV but then everyone would have to know about that toggle. I'm not saying not to use it but we should consider if it is worth the potential trouble seeing as this feature is experimental and already mentions the issue with the font download on the linked page.

keldian commented 10 months ago

Right then, I'm setting assets to false. If you guys decide we don't want privacy at all, I guess you can discard the plugin commits.

saltydk commented 10 months ago

I'll let chaz decide on it as he handles most of the docs these days, just sharing my thoughts on it.

saltydk commented 10 months ago

Can you move this PR to traefik3?

keldian commented 10 months ago

Can you move this PR to traefik3?

Done. Want me to do the same with https://github.com/saltyorg/docs/pull/213?

saltydk commented 10 months ago

Can you move this PR to traefik3?

Done. Want me to do the same with #213?

Sure.

keldian commented 10 months ago

Done.

saltydk commented 9 months ago

main branch has been archived.