Closed keldian closed 9 months ago
The privacy plugin addition adds far more than what you wanted to add it for. Even if you left out the other settings most of them default to true.
Oof, that went over my head.
Looks like it's just assets that would have to be overridden right? To my understanding concurrency and all other asset related options depend on that one being enabled.
Yeah, by default it downloads all external assets and bundles them in the build. All of which probably slows the build time locally, this can be fixed with an ENV but then everyone would have to know about that toggle. I'm not saying not to use it but we should consider if it is worth the potential trouble seeing as this feature is experimental and already mentions the issue with the font download on the linked page.
Right then, I'm setting assets
to false. If you guys decide we don't want privacy
at all, I guess you can discard the plugin commits.
I'll let chaz decide on it as he handles most of the docs these days, just sharing my thoughts on it.
Can you move this PR to traefik3?
Can you move this PR to traefik3?
Done. Want me to do the same with https://github.com/saltyorg/docs/pull/213?
Can you move this PR to traefik3?
Done. Want me to do the same with #213?
Sure.
Done.
main branch has been archived.
Fully previewed and tested using the Insiders edition.
docs/sandbox/index.md
mkdocs.yml
nav menudocs/advanced/healthchecks.md
Also,
extra.css
got linted as I added some things.